New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop installing Matrix Console by default #4290

Merged
merged 1 commit into from Dec 11, 2018

Conversation

3 participants
@richvdh
Member

richvdh commented Dec 11, 2018

This is based on the work done by @krombel in #2601.

Fixes #1417, and kinda fixes #1527.

Stop installing Matrix Console by default
This is based on the work done by @krombel in #2601.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 11, 2018

Codecov Report

Merging #4290 into develop will increase coverage by <.01%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4290      +/-   ##
===========================================
+ Coverage    73.49%   73.49%   +<.01%     
===========================================
  Files          302      302              
  Lines        29892    29893       +1     
  Branches      4887     4892       +5     
===========================================
+ Hits         21968    21969       +1     
+ Misses        6488     6484       -4     
- Partials      1436     1440       +4
Impacted Files Coverage Δ
synapse/python_dependencies.py 40.9% <ø> (ø) ⬆️
synapse/app/homeserver.py 57.52% <42.85%> (+0.66%) ⬆️
synapse/config/server.py 63.79% <60%> (-0.1%) ⬇️
synapse/util/file_consumer.py 80.7% <0%> (-1.76%) ⬇️
synapse/handlers/user_directory.py 70.73% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ac2a5...df96177. Read the comment docs.

@richvdh richvdh requested a review from matrix-org/synapse-core Dec 11, 2018

@richvdh richvdh added this to To Do in Backend Core Team via automation Dec 11, 2018

@richvdh richvdh changed the base branch from develop to release-v0.34.0 Dec 11, 2018

@richvdh richvdh merged commit 1889457 into release-v0.34.0 Dec 11, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Backend Core Team automation moved this from To Do to Done - Operations Dec 11, 2018

richvdh added a commit that referenced this pull request Dec 19, 2018

remove redundant webclient configs
These just emit warnings, as of #4290

richvdh added a commit that referenced this pull request Dec 20, 2018

remove redundant webclient configs
These just emit warnings, as of #4290

richvdh added a commit that referenced this pull request Dec 20, 2018

remove redundant webclient configs
These just emit warnings, as of #4290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment