New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to use new virtualenv (#4328) #4342

Merged
merged 3 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@aaronraimist
Copy link
Contributor

aaronraimist commented Jan 1, 2019

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

Fixes #4328

Should I also update the password reset section to assume you installed Synapse via pypi, so the location of hash_password would be ./env/bin/hash_password instead of ./scripts/hash_password?

aaronraimist added some commits Jan 1, 2019

Update README to use new virtualenv (#4328)
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Add changelog
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 1, 2019

Codecov Report

Merging #4342 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4342      +/-   ##
===========================================
+ Coverage    73.73%   73.75%   +0.01%     
===========================================
  Files          300      300              
  Lines        29751    29751              
  Branches      4878     4878              
===========================================
+ Hits         21938    21942       +4     
+ Misses        6387     6386       -1     
+ Partials      1426     1423       -3
Impacted Files Coverage Δ
synapse/handlers/search.py 80.24% <0%> (ø) ⬆️
synapse/handlers/federation.py 61.72% <0%> (ø) ⬆️
synapse/util/logcontext.py 90.78% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7843f4...dd3bf40. Read the comment docs.

@aaronraimist

This comment has been minimized.

Copy link
Contributor Author

aaronraimist commented Jan 1, 2019

Should I also update the password reset section to assume you installed Synapse via pypi, so the location of hash_password would be ./env/bin/hash_password instead of ./scripts/hash_password?

Or maybe it should just be changed to show how to use the admin api https://github.com/matrix-org/synapse/blob/master/docs/admin_api/user_admin_api.rst#reset-password

@richvdh richvdh self-requested a review Jan 2, 2019

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Jan 2, 2019

Should I also update the password reset section to assume you installed Synapse via pypi, so the location of hash_password would be ./env/bin/hash_password instead of ./scripts/hash_password?

Yes, I think this needs updating. Note that just hash_password works from inside the virtualenv; also that it doesn't matter if you got synapse from pypi or git.

Or maybe it should just be changed to show how to use the admin api https://github.com/matrix-org/synapse/blob/master/docs/admin_api/user_admin_api.rst#reset-password

Well, that requires an admin user, which is a whole extra level of complication, so I'd stick with the script and sql.

@richvdh

richvdh approved these changes Jan 2, 2019

Copy link
Member

richvdh left a comment

thanks!

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Jan 2, 2019

Yes, I think this needs updating.

just did this, since it was trivial

@richvdh richvdh merged commit 8c818af into matrix-org:develop Jan 10, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment