Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFixup docstrings for matrixfederationclient #4368
Conversation
erikjohnston
requested a review
from matrix-org/synapse-core
Jan 9, 2019
erikjohnston
referenced this pull request
Jan 9, 2019
Merged
Use RequestSendFailed when fail to parse content type headers #4362
erikjohnston
merged commit 55c3e85
into
develop
Jan 9, 2019
5 checks passed
ci/circleci: sytestpy2merged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged
Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/better_errors
branch
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
erikjohnston commentedJan 9, 2019
No description provided.