Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix adding new columns instead of updating them if one of the key values is a NULL in upserts. #4369
Conversation
hawkowl
requested a review
from matrix-org/synapse-core
Jan 9, 2019
hawkowl
added this to Holding pen
in Superceded by https://github.com/orgs/matrix-org/projects/8
via automation
Jan 9, 2019
hawkowl
moved this from Holding pen
to Review
in Superceded by https://github.com/orgs/matrix-org/projects/8
Jan 9, 2019
richvdh
requested changes
Jan 9, 2019
synapse/storage/_base.py Outdated
hawkowl
added some commits
Jan 9, 2019
richvdh
requested changes
Jan 9, 2019
synapse/storage/_base.py Outdated
richvdh
reviewed
Jan 9, 2019
synapse/storage/_base.py
Outdated
| @@ -547,11 +547,19 @@ def _simple_upsert_txn(self, txn, table, keyvalues, values, insertion_values={}, | |||
| if lock: | |||
| self.database_engine.lock_table(txn, table) | |||
|
|
|||
| def _getwhere(val): | |||
This comment has been minimized.
This comment has been minimized.
hawkowl
added some commits
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jan 9, 2019
•
Codecov Report
@@ Coverage Diff @@
## develop #4369 +/- ##
===========================================
+ Coverage 73.68% 73.69% +<.01%
===========================================
Files 300 300
Lines 29815 29815
Branches 4895 4895
===========================================
+ Hits 21970 21971 +1
Misses 6407 6407
+ Partials 1438 1437 -1
Continue to review full report at Codecov.
|
hawkowl
merged commit 7960c26
into
develop
Jan 9, 2019
5 checks passed
ci/circleci: sytestpy2merged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged
Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Superceded by https://github.com/orgs/matrix-org/projects/8
automation
moved this from Review
to Done - Operations
Jan 9, 2019
hawkowl
deleted the
hawkowl/nulls-in-upsert
branch
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
hawkowl commentedJan 9, 2019
No description provided.