New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence travis-ci build warnings by removing non-functional python3.6 #4377

Merged
merged 2 commits into from Jan 11, 2019

Conversation

4 participants
@richvdh
Copy link
Member

richvdh commented Jan 11, 2019

see the comments for why this is a not-completely-insane thing to do.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #4377 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4377      +/-   ##
===========================================
+ Coverage    73.65%   73.66%   +<.01%     
===========================================
  Files          300      300              
  Lines        29815    29815              
  Branches      4897     4897              
===========================================
+ Hits         21961    21962       +1     
  Misses        6412     6412              
+ Partials      1442     1441       -1
Impacted Files Coverage Δ
synapse/util/file_consumer.py 82.45% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522dada...6aebe98. Read the comment docs.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 11, 2019

@hawkowl hawkowl merged commit 34b25dc into develop Jan 11, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Superceded by https://github.com/orgs/matrix-org/projects/8 automation moved this from Review to Done - Operations Jan 11, 2019

@hawkowl hawkowl deleted the rav/shut_up_py36_warning branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment