Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
don't store more remote device lists if they have more than 1K devices #4397
Backport of #4396 to develop.
If the remote server has more than ~1000 devices for this user we assume that something is going horribly wrong (e.g. a bot that logs in and creates a new device every time it tries to send a message). Maintaining lots of devices per user in the cache can cause serious performance issues as if this request takes more than 60s to complete, internal replication from the inbound federation worker to the synapse master may time out causing the inbound federation to fail and causing the remote server to retry, causing a DoS. So in this scenario we give up on storing the total list of devices and only handle the delta instead.
@@ Coverage Diff @@ ## develop #4397 +/- ## =========================================== - Coverage 73.65% 73.65% -0.01% =========================================== Files 300 300 Lines 29815 29818 +3 Branches 4897 4898 +1 =========================================== + Hits 21960 21961 +1 Misses 6414 6414 - Partials 1441 1443 +2