New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #4399

Merged
merged 3 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@andrewshadura
Copy link
Contributor

andrewshadura commented Jan 16, 2019

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@andrewshadura andrewshadura changed the title WIP: Update Dependencies Update Dependencies Jan 16, 2019

andrewshadura added some commits Jan 16, 2019

Use msgpack instead of msgpack-python
The package msgpack-python has been deprecated.

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
Depend on pymacaroons >= 0.13.0 instead on pymacaroons-pynacl
Since 0.13.0, pymacaroons works correctly with pynacl, so there
isn’t any more reason to depend on an outdated pynacl fork.

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
Add a changelog entry
Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

@andrewshadura andrewshadura force-pushed the andrewshadura:update-python-deps branch from dcba9b4 to 3b31a54 Jan 16, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4399 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4399   +/-   ##
========================================
  Coverage    73.65%   73.65%           
========================================
  Files          300      300           
  Lines        29815    29815           
  Branches      4897     4897           
========================================
  Hits         21960    21960           
+ Misses        6414     6412    -2     
- Partials      1441     1443    +2
Impacted Files Coverage Δ
synapse/python_dependencies.py 45.83% <ø> (ø) ⬆️
synapse/handlers/search.py 80.24% <0%> (ø) ⬆️
synapse/handlers/federation.py 61.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa955f2...3b31a54. Read the comment docs.

@erikjohnston
Copy link
Member

erikjohnston left a comment

This looks entirely sane, as both packages say they are deprecated in favour of the new ones.

@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Jan 16, 2019

Thanks!

@erikjohnston erikjohnston merged commit 7f1a6a4 into matrix-org:develop Jan 16, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment