New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak code coverage settings #4400

Merged
merged 4 commits into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 16, 2019

They were quite verbose, for not a lot of benefit. Also adds two commit statuses:

  • Project status: the total coverage of the total project
  • Patch status: the total coverage of the diff

Currently they always pass, but we can set a minimum absolute threshold for coverage, or set it so that coverage must be better than the base branch.

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Jan 16, 2019

Well lets see if codecov wakes up and makes of this PR. I've just enabled webhooks so hopefully it'll do something?

erikjohnston added some commits Jan 16, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4400 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4400      +/-   ##
===========================================
+ Coverage    73.65%   73.65%   +<.01%     
===========================================
  Files          300      300              
  Lines        29815    29815              
  Branches      4897     4897              
===========================================
+ Hits         21960    21961       +1     
+ Misses        6414     6412       -2     
- Partials      1441     1442       +1

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 16, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Jan 16, 2019

I don't know what happened to the commit statuses (maybe the config needs to be on the base branch?) but at least the comments are smaller.

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Jan 17, 2019

I'd like to leave this one for @hawkowl since I think she has more experience with codecov. I'm afraid I still don't really understand what the comment or report is trying to tell me.

@hawkowl hawkowl merged commit 71b94ea into develop Jan 18, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the erikj/tune_codecov branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment