New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race when persisting create event #4404

Merged
merged 2 commits into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 16, 2019

Fix race when persisting create event …
When persisting a chunk of DAG it is sometimes requried to do a state
resolution, which requires knowledge of the room version. If this
happens while we're persisting the create event then we need to use that
event rather than attempting to look it up in the database.

Fix race when persisting create event
When persisting a chunk of DAG it is sometimes requried to do a state
resolution, which requires knowledge of the room version. If this
happens while we're persisting the create event then we need to use that
event rather than attempting to look it up in the database.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 16, 2019

@erikjohnston erikjohnston force-pushed the erikj/create_version_race branch from d422eff to 5520f3a Jan 16, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4404 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4404   +/-   ##
========================================
  Coverage    73.65%   73.65%           
========================================
  Files          300      300           
  Lines        29815    29815           
  Branches      4897     4897           
========================================
  Hits         21961    21961           
  Misses        6412     6412           
  Partials      1442     1442

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1a6a4...5520f3a. Read the comment docs.

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@hawkowl hawkowl merged commit 25dd56a into develop Jan 18, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the erikj/create_version_race branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment