New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign_request -> build_auth_headers #4408

Merged
merged 2 commits into from Jan 17, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Jan 16, 2019

I just got very confused about the fact that the headers are only an output, not an input.

richvdh added some commits Jan 16, 2019

sign_request -> build_auth_headers
Just got very confused about the fact that the headers are only an output, not
an input.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4408 into develop will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4408      +/-   ##
===========================================
+ Coverage    73.65%   73.66%   +<.01%     
===========================================
  Files          300      300              
  Lines        29815    29816       +1     
  Branches      4897     4897              
===========================================
+ Hits         21961    21964       +3     
+ Misses        6412     6411       -1     
+ Partials      1442     1441       -1
Impacted Files Coverage Δ
synapse/handlers/identity.py 26.47% <0%> (ø) ⬆️
synapse/http/matrixfederationclient.py 84.09% <100%> (+0.06%) ⬆️
synapse/handlers/user_directory.py 71.08% <0%> (-0.31%) ⬇️
synapse/handlers/device.py 81.45% <0%> (+0.8%) ⬆️
synapse/util/file_consumer.py 82.45% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1a6a4...fde7836. Read the comment docs.

@richvdh richvdh changed the title sign_request -> build_auth_headers I just got very confused about the fact that the headers are only an output, not an input. sign_request -> build_auth_headers Jan 16, 2019

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 16, 2019

@richvdh richvdh merged commit 9feb5d0 into develop Jan 17, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Jan 22, 2019

@richvdh richvdh moved this from To Do to Done in Homeserver Task Board Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment