New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to disable requesting MSISDN on registration #4423

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@neilisfragile
Copy link
Contributor

neilisfragile commented Jan 21, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #4423 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4423      +/-   ##
===========================================
+ Coverage    73.64%   73.65%   +0.01%     
===========================================
  Files          300      300              
  Lines        29801    29803       +2     
  Branches      4896     4896              
===========================================
+ Hits         21947    21952       +5     
+ Misses        6417     6411       -6     
- Partials      1437     1440       +3

@neilisfragile neilisfragile requested a review from matrix-org/synapse-core Jan 21, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm modulo my concerns re testing in #synapse-dev

@neilisfragile

This comment has been minimized.

Copy link
Contributor Author

neilisfragile commented Jan 22, 2019

tested with ios and android - all good. Can't test fully against riot web since it hard codes the msisdn field. The redesign will solve with this, and should modify the form based on the server's capabilities.

With that in mind I will merge but not enable on matrix.org

@neilisfragile neilisfragile merged commit 388c164 into develop Jan 22, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment