New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make key fetches use regular federation client #4426

Merged
merged 3 commits into from Jan 22, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Jan 21, 2019

We may as well just use the regular federation client, which saves alot of
magic.

richvdh added some commits Jan 21, 2019

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 21, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #4426 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4426      +/-   ##
===========================================
+ Coverage    73.64%   73.66%   +0.02%     
===========================================
  Files          300      299       -1     
  Lines        29801    29703      -98     
  Branches      4896     4882      -14     
===========================================
- Hits         21947    21882      -65     
+ Misses        6417     6390      -27     
+ Partials      1437     1431       -6
@@ -514,20 +515,6 @@ def get_server_verify_key_v2_direct(self, server_name, key_ids):
if "tls_fingerprints" not in response:
raise KeyLookupError("Key response missing TLS fingerprints")

certificate_bytes = crypto.dump_certificate(

This comment has been minimized.

@hawkowl

hawkowl Jan 22, 2019

Contributor

Does this matter?

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Jan 22, 2019

@richvdh richvdh moved this from To Do to In progress in Homeserver Task Board Jan 22, 2019

@hawkowl
Copy link
Contributor

hawkowl left a comment

lgtm

Remove redundant check for tls_fingerprints
We don't need this any more, and we are likely to remove it from the spec soon
enough.

@richvdh richvdh merged commit 6bfa735 into develop Jan 22, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/kill_keyclient branch Jan 22, 2019

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment