New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and bugfix for resove_service #4427

Merged
merged 8 commits into from Jan 22, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Jan 21, 2019

This PR has several commits, each of which should make sense on its own.

richvdh added some commits Jan 14, 2019

Move resolve_service to its own file
This is useful outside endpoints.
namedtuple must die
use an attrs instead of a namedtuple for resolve_service
Flatten exception handling
I don't know why this needs to be nested so deep.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 21, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #4427 into develop will increase coverage by 0.02%.
The diff coverage is 89.58%.

@@             Coverage Diff             @@
##           develop    #4427      +/-   ##
===========================================
+ Coverage    73.64%   73.67%   +0.02%     
===========================================
  Files          300      301       +1     
  Lines        29801    29812      +11     
  Branches      4896     4898       +2     
===========================================
+ Hits         21947    21963      +16     
+ Misses        6417     6411       -6     
- Partials      1437     1438       +1
@hawkowl
Copy link
Contributor

hawkowl left a comment

Looks reasonable.

The coverage is a bit spotty, I would like some tests covering the yellow in srv_resolver if that's possible: https://codecov.io/gh/matrix-org/synapse/pull/4427/diff

@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jan 22, 2019

The coverage is a bit spotty, I would like some tests covering the yellow in srv_resolver if that's possible: https://codecov.io/gh/matrix-org/synapse/pull/4427/diff

Fair. will add some more testing.

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Jan 22, 2019

@richvdh richvdh moved this from To Do to In progress in Homeserver Task Board Jan 22, 2019

@richvdh richvdh self-assigned this Jan 22, 2019

richvdh added some commits Jan 22, 2019

Fix type of 'host' field in Server
this should be a bytes, not a str.

@richvdh richvdh requested a review from hawkowl Jan 22, 2019

@richvdh richvdh merged commit 33a5528 into develop Jan 22, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/refactor_resolve_service branch Jan 22, 2019

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment