New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup removal of duplicate `user_ips` rows #4432

Merged
merged 3 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 22, 2019

This includes a few changes that should hopefully make it a bit cleaner.

Now based on #4434

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #4432 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4432      +/-   ##
==========================================
- Coverage     73.7%   73.7%   -0.01%     
==========================================
  Files          300     300              
  Lines        29705   29705              
  Branches      4882    4882              
==========================================
- Hits         21895   21894       -1     
+ Misses        6385    6383       -2     
- Partials      1425    1428       +3

@erikjohnston erikjohnston force-pushed the erikj/fixup_remove_old_user_ips branch 2 times, most recently from 7aac8fc to 1b3cc39 Jan 22, 2019

@erikjohnston erikjohnston force-pushed the erikj/fixup_remove_old_user_ips branch from 1b3cc39 to 6e05f9b Jan 22, 2019

@erikjohnston erikjohnston force-pushed the erikj/fixup_remove_old_user_ips branch from 6e05f9b to 2f947b7 Jan 22, 2019

@hawkowl hawkowl merged commit 90743c9 into develop Jan 23, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the erikj/fixup_remove_old_user_ips branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment