New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian package: symlink to python-3.X #4433

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Jan 22, 2019

In the debian package, make the virtualenv symlink python to /usr/bin/python3.X rather than /usr/bin/python3. Also make sure we depend on the right python3.x package.

This might help a bit with subtle failures when people install a package from the wrong distro (#4431).

(aside: this stuff really ought to go into the debian changelog, rather than the main changelog. how hard would it be to make the CI check if debian/changelog is updated when the debian directory is updated, instead of changelog.d?)

richvdh added some commits Jan 22, 2019

debian package: symlink to python-3.X
In the debian package, make the virtualenv symlink python to /usr/bin/python3.X
rather than /usr/bin/python3. Also make sure we depend on the right python3.x
package.

This might help a bit with subtle failures when people install a package from
the wrong distro (#4431).
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #4433 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4433   +/-   ##
========================================
  Coverage    73.68%   73.68%           
========================================
  Files          300      300           
  Lines        29703    29703           
  Branches      4882     4882           
========================================
  Hits         21887    21887           
- Misses        6386     6387    +1     
+ Partials      1430     1429    -1

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 22, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Jan 23, 2019

My only concern is that if people upgrade/replace their python version things will break? But from the bug it sounds like that would break already?

@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jan 23, 2019

My only concern is that if people upgrade/replace their python version things will break? But from the bug it sounds like that would break already?

Yes it would. Better to make the dependency explicit.

@erikjohnston
Copy link
Member

erikjohnston left a comment

Seems reasonable to me.

@richvdh richvdh merged commit 2f88881 into develop Jan 23, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment