New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the debian config during build #4444

Merged
merged 2 commits into from Jan 24, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Jan 23, 2019

Rather than hardcoding a config which we always forget to update, generate it
from the default config.

A diff between what we had before and the generated file is at https://matrix.sw1v.org/_matrix/media/v1/download/sw1v.org/QUSWvfnHXnSsDtxQSSKTSMfE.

Fixes #4441.

Generate the debian config during build
Rather than hardcoding a config which we always forget to update, generate it
from the default config.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4444 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4444      +/-   ##
===========================================
- Coverage    73.61%   73.58%   -0.03%     
===========================================
  Files          301      301              
  Lines        29822    29822              
  Branches      4894     4894              
===========================================
- Hits         21953    21945       -8     
- Misses        6440     6447       +7     
- Partials      1429     1430       +1
@hawkowl

This comment has been minimized.

Copy link
Contributor

hawkowl commented Jan 24, 2019

lgtm

@richvdh richvdh merged commit 8c58c10 into develop Jan 24, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Superceded by https://github.com/orgs/matrix-org/projects/8 automation moved this from Review to Done - Operations Jan 24, 2019

@richvdh richvdh deleted the rav/deb_config branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment