Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for optional dependencies #4450

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@14mRh4X0r
Copy link
Contributor

14mRh4X0r commented Jan 23, 2019

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off
Fix error message for optional dependencies
Signed-off-by: Willem Mulder <willemmaster@hotmail.com>

@14mRh4X0r 14mRh4X0r force-pushed the 14mRh4X0r:fix-dependency-message branch from 277bf40 to d528406 Jan 23, 2019

@14mRh4X0r 14mRh4X0r changed the title [WIP] Fix error message for optional dependencies Fix error message for optional dependencies Jan 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4450 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #4450      +/-   ##
===========================================
+ Coverage    73.64%   73.67%   +0.02%     
===========================================
  Files          302      302              
  Lines        29818    29818              
  Branches      4895     4895              
===========================================
+ Hits         21960    21968       +8     
+ Misses        6426     6417       -9     
- Partials      1432     1433       +1
@richvdh
Copy link
Member

richvdh left a comment

lgtm, thanks!

@richvdh richvdh merged commit c6e75c9 into matrix-org:develop Feb 13, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.