New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send IP addresses as SNI #4452

Merged
merged 2 commits into from Jan 24, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Jan 23, 2019

The problem here is that we have cut-and-pasted an impl from Twisted, and
then failed to maintain it. It was fixed in Twisted in
https://github.com/twisted/twisted/pull/1047/files; let's do the same here.

richvdh added some commits Jan 23, 2019

Don't send IP addresses as SNI
The problem here is that we have cut-and-pasted an impl from Twisted, and then
failed to maintain it. It was fixed in Twisted in
https://github.com/twisted/twisted/pull/1047/files; let's do the same here.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4452 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4452      +/-   ##
===========================================
+ Coverage    73.64%   73.67%   +0.02%     
===========================================
  Files          302      302              
  Lines        29818    29822       +4     
  Branches      4895     4896       +1     
===========================================
+ Hits         21960    21971      +11     
+ Misses        6426     6421       -5     
+ Partials      1432     1430       -2

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Jan 24, 2019

@erikjohnston
Copy link
Member

erikjohnston left a comment

Looks legit

@richvdh richvdh merged commit 97fd29c into develop Jan 24, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh moved this from To Do to Done in Homeserver Task Board Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment