New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for public_baseurl #4458

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@dbkr
Copy link
Member

dbkr commented Jan 24, 2019

This is leading to problems with people upgrading to clients that
support MSC1730 because people have this misconfigured, so try
to make the docs completely unambiguous.

NB. In a world without ACME support I probably would have also remove the 8448 from the example URL as this would never have worked, being a self-signed cert, but I guess now this is a plausible default, although it still feels like it's directing you towards it being the internal URL. wdyt?

dbkr added some commits Jan 24, 2019

Clarify docs for public_baseurl
This is leading to problems with people upgrading to clients that
support MSC1730 because people have this misconfigured, so try
to make the docs completely unambiguous.

@dbkr dbkr requested a review from matrix-org/synapse-core Jan 24, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #4458 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4458      +/-   ##
==========================================
+ Coverage    74.79%   74.8%   +0.01%     
==========================================
  Files          336     336              
  Lines        33997   33997              
  Branches      5527    5527              
==========================================
+ Hits         25429   25433       +4     
+ Misses        7002    7001       -1     
+ Partials      1566    1563       -3

@neilisfragile neilisfragile merged commit 5c41b22 into develop Jan 24, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment