Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify docs for public_baseurl #4458
Conversation
dbkr
added some commits
Jan 24, 2019
dbkr
requested a review
from matrix-org/synapse-core
Jan 24, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jan 24, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4458 +/- ##
==========================================
+ Coverage 74.79% 74.8% +0.01%
==========================================
Files 336 336
Lines 33997 33997
Branches 5527 5527
==========================================
+ Hits 25429 25433 +4
+ Misses 7002 7001 -1
+ Partials 1566 1563 -3 |
neilisfragile
approved these changes
Jan 24, 2019
neilisfragile
merged commit 5c41b22
into
develop
Jan 24, 2019
5 checks passed
ci/circleci: sytestpy2merged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged
Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged
Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dbkr commentedJan 24, 2019
•
edited
This is leading to problems with people upgrading to clients that
support MSC1730 because people have this misconfigured, so try
to make the docs completely unambiguous.
NB. In a world without ACME support I probably would have also remove the 8448 from the example URL as this would never have worked, being a self-signed cert, but I guess now this is a plausible default, although it still feels like it's directing you towards it being the internal URL. wdyt?