New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnboundLocalError in post_urlencoded_get_json #4460

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Jan 24, 2019

This could cause exceptions if the id server returned 4xx responses.

(it got broken in 2d2828d)

Fix UnboundLocalError in post_urlencoded_get_json
This could cause exceptions if the id server returned 4xx responses.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 24, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #4460 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4460      +/-   ##
===========================================
+ Coverage    74.79%   74.82%   +0.02%     
===========================================
  Files          336      336              
  Lines        33997    33997              
  Branches      5527     5527              
===========================================
+ Hits         25429    25439      +10     
+ Misses        7002     6991      -11     
- Partials      1566     1567       +1

@richvdh richvdh merged commit f4697b5 into develop Jan 24, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_unbound_local_error branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment