Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter user directory state query to a subset of state events #4462

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@anoadragon453
Copy link
Member

anoadragon453 commented Jan 24, 2019

Don't request all state events from a room, just those we need.

Should help slightly with DB hammering from the user directory.

@anoadragon453

This comment has been minimized.

Copy link
Member Author

anoadragon453 commented Jan 24, 2019

Blocked by testing on hotfixes branch.

@anoadragon453 anoadragon453 force-pushed the anoa/user_dir_filter_state branch from 00c145c to cc410f9 Jan 24, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #4462 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4462      +/-   ##
===========================================
+ Coverage    74.83%   74.83%   +<.01%     
===========================================
  Files          336      336              
  Lines        34000    34002       +2     
  Branches      5528     5528              
===========================================
+ Hits         25443    25445       +2     
+ Misses        6993     6992       -1     
- Partials      1564     1565       +1
@@ -0,0 +1 @@
Change the user directory state query to use a filtered call to the db instead of a generic one.

This comment has been minimized.

Copy link
@anoadragon453

anoadragon453 Jan 25, 2019

Author Member

Hm, is a changelog even worth it for this change?

This comment has been minimized.

Copy link
@hawkowl

hawkowl Jan 29, 2019

Contributor

yes, every change needs a changelog.

@hawkowl

This comment has been minimized.

Copy link
Contributor

hawkowl commented Jan 30, 2019

@anoadragon453 ping -- is this tested well enough to merge?

@anoadragon453

This comment has been minimized.

Copy link
Member Author

anoadragon453 commented Jan 30, 2019

Yes, testing on hotfixes was good.

@hawkowl

hawkowl approved these changes Feb 5, 2019

@hawkowl hawkowl merged commit 627ecd3 into develop Feb 5, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the anoa/user_dir_filter_state branch Feb 5, 2019

richvdh added a commit that referenced this pull request Feb 14, 2019

Merge tag 'v0.99.1'
Synapse 0.99.1 (2019-02-14)
===========================

Features
--------

- Include m.room.encryption on invites by default ([\#3902](#3902))
- Federation OpenID listener resource can now be activated even if federation is disabled ([\#4420](#4420))
- Synapse's ACME support will now correctly reprovision a certificate that approaches its expiry while Synapse is running. ([\#4522](#4522))
- Add ability to update backup versions ([\#4580](#4580))
- Allow the "unavailable" presence status for /sync.
  This change makes Synapse compliant with r0.4.0 of the Client-Server specification. ([\#4592](#4592))
- There is no longer any need to specify `no_tls`: it is inferred from the absence of TLS listeners ([\#4613](#4613), [\#4615](#4615), [\#4617](#4617), [\#4636](#4636))
- The default configuration no longer requires TLS certificates. ([\#4614](#4614))

Bugfixes
--------

- Copy over room federation ability on room upgrade. ([\#4530](#4530))
- Fix noisy "twisted.internet.task.TaskStopped" errors in logs ([\#4546](#4546))
- Synapse is now tolerant of the `tls_fingerprints` option being None or not specified. ([\#4589](#4589))
- Fix 'no unique or exclusion constraint' error ([\#4591](#4591))
- Transfer Server ACLs on room upgrade. ([\#4608](#4608))
- Fix failure to start when not TLS certificate was given even if TLS was disabled. ([\#4618](#4618))
- Fix self-signed cert notice from generate-config. ([\#4625](#4625))
- Fix performance of `user_ips` table deduplication background update ([\#4626](#4626), [\#4627](#4627))

Internal Changes
----------------

- Change the user directory state query to use a filtered call to the db instead of a generic one. ([\#4462](#4462))
- Reject federation transactions if they include more than 50 PDUs or 100 EDUs. ([\#4513](#4513))
- Reduce duplication of ``synapse.app`` code. ([\#4567](#4567))
- Fix docker upload job to push -py2 images. ([\#4576](#4576))
- Add port configuration information to ACME instructions. ([\#4578](#4578))
- Update MSC1711 FAQ to calrify .well-known usage ([\#4584](#4584))
- Clean up default listener configuration ([\#4586](#4586))
- Clarifications for reverse proxy docs ([\#4607](#4607))
- Move ClientTLSOptionsFactory init out of `refresh_certificates` ([\#4611](#4611))
- Fail cleanly if listener config lacks a 'port' ([\#4616](#4616))
- Remove redundant entries from docker config ([\#4619](#4619))
- README updates ([\#4621](#4621))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.