New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require sqlite3 when using postgres #4466

Merged
merged 3 commits into from Jan 25, 2019

Conversation

Projects
None yet
4 participants
@anoadragon453
Copy link
Member

anoadragon453 commented Jan 24, 2019

There's no need to import and use sqlite3 if you're using postgres as your db backend.

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Jan 24, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #4466 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4466      +/-   ##
===========================================
+ Coverage     74.7%   74.72%   +0.01%     
===========================================
  Files          336      336              
  Lines        35041    34056     -985     
  Branches      5875     5538     -337     
===========================================
- Hits         26179    25448     -731     
+ Misses        7237     7036     -201     
+ Partials      1625     1572      -53
Impacted Files Coverage Δ
synapse/storage/engines/sqlite.py 100% <100%> (ø) ⬆️
synapse/util/frozenutils.py 23.33% <0%> (-30%) ⬇️
synapse/handlers/search.py 74.01% <0%> (-6.24%) ⬇️
synapse/events/__init__.py 87.82% <0%> (-5.3%) ⬇️
synapse/federation/federation_client.py 71.95% <0%> (-3.68%) ⬇️
synapse/handlers/federation.py 61.43% <0%> (-2.91%) ⬇️
synapse/api/filtering.py 95.42% <0%> (-1.9%) ⬇️
synapse/storage/state.py 84.9% <0%> (-1.67%) ⬇️
synapse/handlers/user_directory.py 71.25% <0%> (-0.3%) ⬇️
synapse/federation/federation_base.py 68.62% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c396a...427b093. Read the comment docs.

@richvdh
Copy link
Member

richvdh left a comment

lgtm apart from the changelog

Show resolved Hide resolved changelog.d/4466.misc Outdated
@anoadragon453

This comment has been minimized.

Copy link
Member Author

anoadragon453 commented Jan 24, 2019

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Jan 25, 2019

@hawkowl hawkowl merged commit 0b3fd14 into develop Jan 25, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the anoa/sqlite_no branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment