Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neilj/fix threepid auth check (with tests) #4474

Merged
merged 4 commits into from Apr 1, 2019

Conversation

3 participants
@neilisfragile
Copy link
Contributor

commented Jan 25, 2019

No description provided.

@neilisfragile neilisfragile changed the base branch from master to develop Jan 25, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 30, 2019

Codecov Report

Merging #4474 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4474   +/-   ##
========================================
  Coverage    60.57%   60.57%           
========================================
  Files          331      331           
  Lines        34213    34213           
  Branches      5655     5655           
========================================
  Hits         20723    20723           
- Misses       12012    12015    +3     
+ Partials      1478     1475    -3

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Mar 19, 2019

@neilisfragile neilisfragile requested a review from matrix-org/synapse-core Mar 26, 2019

@neilisfragile

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Tests for #4435

@richvdh

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

please could you merge latest develop into this to check the CI still passes?

@richvdh
Copy link
Member

left a comment

^

neilisfragile added some commits Mar 30, 2019

.

CI passes

@neilisfragile neilisfragile merged commit 4c552ed into develop Apr 1, 2019

24 checks passed

buildkite/synapse Build #695 passed (13 minutes, 48 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 5 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pep-8 Passed (52 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 52 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 13 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 4 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (8 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 50 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 215c15d...5fc44c8
Details
codecov/project 60.57% (target 0%)
Details

Homeserver Task Board automation moved this from In progress to Done Apr 1, 2019

@neilisfragile neilisfragile deleted the neilj/fix_threepid_auth_check branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.