New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through room version to event auth #4482

Merged
merged 3 commits into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 25, 2019

No description provided.

erikjohnston added some commits Jan 25, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 25, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #4482 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4482      +/-   ##
===========================================
+ Coverage    74.71%   74.74%   +0.02%     
===========================================
  Files          336      336              
  Lines        34102    34152      +50     
  Branches      5544     5554      +10     
===========================================
+ Hits         25481    25527      +46     
  Misses        7048     7048              
- Partials      1573     1577       +4
@richvdh
Copy link
Member

richvdh left a comment

lgtm

@@ -611,8 +611,13 @@ def handle_new_client_event(
extra_users (list(UserID)): Any extra users to notify about event
"""

if event.is_state() and (event.type, event.state_key) == (EventTypes.Create, ""):
room_version = event.content["room_version"]

This comment has been minimized.

@richvdh

richvdh Jan 28, 2019

Member

I reckon you can get here without there being a room_version, if you hit PUT /rooms/<room_id>/state/m.room.create. Obviously that's a silly thing to do, but blowing up with an exception doesn't seem like the right thing to do.

This comment has been minimized.

@erikjohnston

erikjohnston Jan 28, 2019

Author Member

Fair, though I'd be surprised if we actually let people send a create event if they're not in the room.

@erikjohnston erikjohnston merged commit f1a0446 into develop Jan 28, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment