New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring in MatrixFederationAgent #4488

Merged
merged 4 commits into from Jan 28, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Jan 27, 2019

Split the routing out and handle IP literals separately.

@richvdh richvdh changed the title Refactorint in MatrixFederationAgent Refactoring in MatrixFederationAgent Jan 28, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #4488 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4488      +/-   ##
===========================================
+ Coverage    74.71%   74.73%   +0.01%     
===========================================
  Files          336      336              
  Lines        34099    34122      +23     
  Branches      5544     5547       +3     
===========================================
+ Hits         25477    25501      +24     
+ Misses        7048     7047       -1     
  Partials      1574     1574

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 28, 2019

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Jan 28, 2019

@richvdh richvdh moved this from To Do to In progress in Homeserver Task Board Jan 28, 2019


@attr.s
class _RoutingResult(object):
host_header = attr.ib()

This comment has been minimized.

@erikjohnston

erikjohnston Jan 28, 2019

Member

A docstring would be good here. Specifically how this interacts with SRV records returning multiple answers; this seems to be a possible route, rather than all possible routes.

richvdh added some commits Jan 26, 2019

Handle IP literals explicitly
We don't want to be doing .well-known lookups on these guys.
MatrixFederationAgent: factor out routing logic
This is going to get too big and unmanageable.

@richvdh richvdh force-pushed the rav/fed_routing/refactor branch from 82b833e to ff05ad1 Jan 28, 2019

@richvdh richvdh merged commit d04ff2a into develop Jan 28, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Jan 29, 2019

@richvdh richvdh deleted the rav/fed_routing/refactor branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment