New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SimpleResolverComplexifier in tests #4497

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Jan 28, 2019

two reasons for this. One, it saves a bunch of boilerplate. Two, it squashes
unicode to IDNA-in-a-str (even on python 3) in a way that it turns out we
rely on to give consistent behaviour between python 2 and 3.

Use SimpleResolverComplexifier in tests
two reasons for this. One, it saves a bunch of boilerplate. Two, it squashes
unicode to IDNA-in-a-`str` (even on python 3) in a way that it turns out we
rely on to give consistent behaviour between python 2 and 3.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #4497 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4497      +/-   ##
===========================================
+ Coverage    74.73%   74.73%   +<.01%     
===========================================
  Files          336      336              
  Lines        34148    34148              
  Branches      5553     5553              
===========================================
+ Hits         25520    25522       +2     
+ Misses        7049     7048       -1     
+ Partials      1579     1578       -1

@hawkowl hawkowl merged commit f2b553d into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the rav/test_resolver_fixes branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment