New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linearizer more quiet #4507

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
None yet
5 participants
@hawkowl
Copy link
Contributor

hawkowl commented Jan 29, 2019

It's like 25% of our logs and not very useful at INFO

hawkowl added some commits Jan 29, 2019

@hawkowl hawkowl requested a review from matrix-org/synapse-core Jan 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #4507 into develop will decrease coverage by <.01%.
The diff coverage is 80%.

@@             Coverage Diff             @@
##           develop    #4507      +/-   ##
===========================================
- Coverage    74.75%   74.75%   -0.01%     
===========================================
  Files          336      336              
  Lines        34156    34156              
  Branches      5554     5554              
===========================================
- Hits         25535    25534       -1     
  Misses        7046     7046              
- Partials      1575     1576       +1
@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Jan 29, 2019

FTR, the reason why this was added was that it helped track down bugs where synapse would lock up entirely (due to one instances taking out the lock and then blocking).

I agree that they're really noisy.

@richvdh
Copy link
Member

richvdh left a comment

we might find ourselves needing to turn them back up again (or replace them with something more targeted), but lgtm

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jan 29, 2019

tracing these (very noisy) lineariser logs was the only way that mjark & I were able to diagnose the locks which led to the federation meltdown of Dec 2016, fwiw. i subsequently have used them quite a lot to see which locks are causing deadlocks and meltdowns. i find myself echoing vdh's last comment.

@hawkowl hawkowl merged commit f815bd7 into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the hawkowl/quiet-linearizer branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment