New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup calls to `comput_event_signature` #4510

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 29, 2019

We currently pass FrozenEvent instead of dict to
compute_event_signature, which works by accident due to dict(event)
producing the correct result.

erikjohnston added some commits Jan 29, 2019

Fixup calls to `comput_event_signature`
We currently pass FrozenEvent instead of `dict` to
`compute_event_signature`, which works by accident due to `dict(event)`
producing the correct result.

This fixes PR #4493 commit 855a151

@erikjohnston erikjohnston force-pushed the erikj/fixup_compute_event_signature branch from fcb8eb6 to 0c55b77 Jan 29, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 29, 2019

@richvdh
Copy link
Member

richvdh left a comment

looks like this got broken in #4493 ?

lgtm

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #4510 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4510      +/-   ##
===========================================
- Coverage    74.76%   74.76%   -0.01%     
===========================================
  Files          336      336              
  Lines        34180    34180              
  Branches      5559     5559              
===========================================
- Hits         25556    25554       -2     
- Misses        7048     7049       +1     
- Partials      1576     1577       +1
@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Jan 29, 2019

looks like this got broken in #4493 ?

Yup thanks, its in the commit comment but forgot to update the PR comment

@erikjohnston erikjohnston merged commit 2562319 into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment