New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for room version 3 #4515

Merged
merged 3 commits into from Jan 29, 2019

Conversation

3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 29, 2019

Based on #4499, #4514 and #4483

@erikjohnston erikjohnston force-pushed the erikj/room_version_v3 branch from 126ab94 to 18723db Jan 29, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 29, 2019

@erikjohnston erikjohnston added this to To Do in Homeserver Task Board via automation Jan 29, 2019

@erikjohnston erikjohnston moved this from To Do to In progress in Homeserver Task Board Jan 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #4515 into develop will increase coverage by 0.02%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #4515      +/-   ##
===========================================
+ Coverage    74.69%   74.72%   +0.02%     
===========================================
  Files          336      336              
  Lines        34288    34293       +5     
  Branches      5590     5592       +2     
===========================================
+ Hits         25611    25625      +14     
+ Misses        7092     7080      -12     
- Partials      1585     1588       +3

@erikjohnston erikjohnston force-pushed the erikj/room_version_v3 branch from c82ef4b to ebcffbc Jan 29, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm otherwise

@@ -274,7 +274,10 @@ def _check_sigs_on_pdus(keyring, room_version, pdus):
# now let's look for events where the sender's domain is different to the
# event id's domain (normally only the case for joins/leaves), and add additional
# checks. Only do this if the room version has a concept of event ID domain
if room_version in KNOWN_ROOM_VERSIONS:
if room_version in (
RoomVersions.V1, RoomVersions.V2, RoomVersions.VDH_TEST,

This comment has been minimized.

@richvdh

richvdh Jan 29, 2019

Member

no vdh here

@erikjohnston erikjohnston merged commit 47d03a7 into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston moved this from In progress to Done in Homeserver Task Board Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment