Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACME Reprovisioning #4522

Merged
merged 51 commits into from Feb 11, 2019

Conversation

Projects
None yet
4 participants
@hawkowl
Copy link
Contributor

hawkowl commented Jan 30, 2019

Fixes #4455

hawkowl added some commits Jan 24, 2019

fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix
fix

@hawkowl hawkowl requested a review from matrix-org/synapse-core Jan 30, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Jan 30, 2019

I just tested this with sytest against a worker config and the thing still starts 👍

@richvdh
Copy link
Member

richvdh left a comment

as per #synapse: please could you break this up to try to separate the refactoring and the functional changes.

hawkowl added some commits Feb 5, 2019

fix
@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Feb 8, 2019

based on #4567

stale

@hawkowl hawkowl requested a review from matrix-org/synapse-core Feb 8, 2019

@richvdh
Copy link
Member

richvdh left a comment

looks plausible. I'm a bit confused about the _listening_services thing though. What are the entries of that list supposed to be?

As far as I can tell by reverse-engineering it, they are twisted.internet.tcp.Ports, but such things don't seem to have (documented) factory attributes?

I don't particularly object to us poking the undocumented innards of twisted if that's the best way to achieve our objective, but please could we have some comments to explain what's going on, and to document the type of _listening_services ?

@hawkowl hawkowl requested a review from matrix-org/synapse-core Feb 11, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@richvdh richvdh merged commit 6e2a5aa into develop Feb 11, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the hawkowl/acme-reprovision branch Feb 11, 2019

richvdh added a commit that referenced this pull request Feb 14, 2019

Merge tag 'v0.99.1'
Synapse 0.99.1 (2019-02-14)
===========================

Features
--------

- Include m.room.encryption on invites by default ([\#3902](#3902))
- Federation OpenID listener resource can now be activated even if federation is disabled ([\#4420](#4420))
- Synapse's ACME support will now correctly reprovision a certificate that approaches its expiry while Synapse is running. ([\#4522](#4522))
- Add ability to update backup versions ([\#4580](#4580))
- Allow the "unavailable" presence status for /sync.
  This change makes Synapse compliant with r0.4.0 of the Client-Server specification. ([\#4592](#4592))
- There is no longer any need to specify `no_tls`: it is inferred from the absence of TLS listeners ([\#4613](#4613), [\#4615](#4615), [\#4617](#4617), [\#4636](#4636))
- The default configuration no longer requires TLS certificates. ([\#4614](#4614))

Bugfixes
--------

- Copy over room federation ability on room upgrade. ([\#4530](#4530))
- Fix noisy "twisted.internet.task.TaskStopped" errors in logs ([\#4546](#4546))
- Synapse is now tolerant of the `tls_fingerprints` option being None or not specified. ([\#4589](#4589))
- Fix 'no unique or exclusion constraint' error ([\#4591](#4591))
- Transfer Server ACLs on room upgrade. ([\#4608](#4608))
- Fix failure to start when not TLS certificate was given even if TLS was disabled. ([\#4618](#4618))
- Fix self-signed cert notice from generate-config. ([\#4625](#4625))
- Fix performance of `user_ips` table deduplication background update ([\#4626](#4626), [\#4627](#4627))

Internal Changes
----------------

- Change the user directory state query to use a filtered call to the db instead of a generic one. ([\#4462](#4462))
- Reject federation transactions if they include more than 50 PDUs or 100 EDUs. ([\#4513](#4513))
- Reduce duplication of ``synapse.app`` code. ([\#4567](#4567))
- Fix docker upload job to push -py2 images. ([\#4576](#4576))
- Add port configuration information to ACME instructions. ([\#4578](#4578))
- Update MSC1711 FAQ to calrify .well-known usage ([\#4584](#4584))
- Clean up default listener configuration ([\#4586](#4586))
- Clarifications for reverse proxy docs ([\#4607](#4607))
- Move ClientTLSOptionsFactory init out of `refresh_certificates` ([\#4611](#4611))
- Fail cleanly if listener config lacks a 'port' ([\#4616](#4616))
- Remove redundant entries from docker config ([\#4619](#4619))
- README updates ([\#4621](#4621))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.