New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where synapse fails to start if no_tls set #4524

Merged
merged 3 commits into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 30, 2019

Introduced in #4495

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 30, 2019

@erikjohnston erikjohnston removed the request for review from matrix-org/synapse-core Jan 30, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #4524 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #4524      +/-   ##
===========================================
+ Coverage     74.7%   74.73%   +0.03%     
===========================================
  Files          337      337              
  Lines        34447    34447              
  Branches      5615     5615              
===========================================
+ Hits         25732    25745      +13     
+ Misses        7124     7111      -13     
  Partials      1591     1591

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 30, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 43c6fca into develop Jan 30, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

gdamjan added a commit to gdamjan/synapse that referenced this pull request Feb 12, 2019

implement `reload` by sending the HUP signal
According to the 0.99 release info* synapse now uses the HUP signal to reload certificates:
> Synapse will now reload TLS certificates from disk upon SIGHUP. (matrix-org#4495, matrix-org#4524)

So the matrix-synapse.service unit file should include a reload directive.

* https://github.com/matrix-org/synapse/releases/tag/v0.99.0

gdamjan added a commit to gdamjan/synapse that referenced this pull request Feb 12, 2019

implement `reload` by sending the HUP signal
According to the 0.99 release info* synapse now uses the HUP signal to reload certificates:
> Synapse will now reload TLS certificates from disk upon SIGHUP. (matrix-org#4495, matrix-org#4524)

So the matrix-synapse.service unit file should include a reload directive.

* https://github.com/matrix-org/synapse/releases/tag/v0.99.0

gdamjan added a commit to gdamjan/synapse that referenced this pull request Feb 12, 2019

implement `reload` by sending the HUP signal
According to the 0.99 release info* synapse now uses the HUP signal to reload certificates:
> Synapse will now reload TLS certificates from disk upon SIGHUP. (matrix-org#4495, matrix-org#4524)

So the matrix-synapse.service unit file should include a reload directive.

* https://github.com/matrix-org/synapse/releases/tag/v0.99.0

Signed-off-by: Дамјан Георгиевски <gdamjan@gmail.com>

richvdh added a commit that referenced this pull request Feb 14, 2019

implement `reload` by sending the HUP signal (#4622)
* implement `reload` by sending the HUP signal

According to the 0.99 release info* synapse now uses the HUP signal to reload certificates:

> Synapse will now reload TLS certificates from disk upon SIGHUP. (#4495, #4524)

So the matrix-synapse.service unit file should include a reload directive.

Signed-off-by: Дамјан Георгиевски <gdamjan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment