New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote invite rejections not coming down sync #4527

Merged
merged 2 commits into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 30, 2019

This was broken in PR #4405, commit 886e5ac, where we changed remote
rejections to be outliers.

The fix is to explicitly add the leave event in when we know its an out
of band invite. We can't always add the event as if the server is/was in
the room there might be more events to send down the sync than just the
leave.

Fix remote invite rejections not comming down sync
This was broken in PR #4405, commit 886e5ac, where we changed remote
rejections to be outliers.

The fix is to explicitly add the leave event in when we know its an out
of band invite. We can't always add the event as if the server is/was in
the room there might be more events to send down the sync than just the
leave.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 30, 2019

@hawkowl hawkowl changed the title Fix remote invite rejections not comming down sync Fix remote invite rejections not coming down sync Jan 30, 2019

@richvdh
Copy link
Member

richvdh left a comment

ltgm I guess 🤷‍♂️

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #4527 into develop will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #4527      +/-   ##
===========================================
- Coverage    74.74%   74.73%   -0.02%     
===========================================
  Files          338      338              
  Lines        34481    34484       +3     
  Branches      5616     5617       +1     
===========================================
- Hits         25772    25770       -2     
- Misses        7122     7123       +1     
- Partials      1587     1591       +4

@erikjohnston erikjohnston merged commit d534a27 into develop Jan 30, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment