New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat an invalid .well-known the same as an absent one #4544

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@richvdh
Copy link
Member

richvdh commented Feb 1, 2019

... basically, carry on and fall back to SRV etc.

Turns out a bunch of people return 200s to .well-known requests, but don't serve up valid .well-knowns

Treat an invalid .well-known the same as an absent one
... basically, carry on and fall back to SRV etc.

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 1, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #4544 into release-v0.99.0 will decrease coverage by 0.4%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           release-v0.99.0    #4544      +/-   ##
===================================================
- Coverage            74.87%   74.46%   -0.41%     
===================================================
  Files                  338      338              
  Lines                34504    35087     +583     
  Branches              5620     5789     +169     
===================================================
+ Hits                 25835    26128     +293     
- Misses                7086     7347     +261     
- Partials              1583     1612      +29
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Feb 1, 2019

nobody seems to be about to review PRs :/

@richvdh richvdh merged commit fa79498 into release-v0.99.0 Feb 1, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/skip_invalid_well_known branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment