New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in config comments #4557

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@richvdh
Copy link
Member

richvdh commented Feb 4, 2019

No description provided.

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 4, 2019

@t3chguy
Copy link
Contributor

t3chguy left a comment

Looks good otherwise

@@ -0,0 +1 @@
Fix comment typo in acme section of config

This comment has been minimized.

@t3chguy

t3chguy Feb 4, 2019

Contributor

its not in the acme section though

This comment has been minimized.

@richvdh

richvdh Feb 4, 2019

Author Member

le sigh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #4557 into release-v0.99.0 will decrease coverage by 0.43%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-v0.99.0    #4557      +/-   ##
===================================================
- Coverage            74.91%   74.48%   -0.44%     
===================================================
  Files                  338      338              
  Lines                34495    35093     +598     
  Branches              5619     5789     +170     
===================================================
+ Hits                 25841    26138     +297     
- Misses                7071     7345     +274     
- Partials              1583     1610      +27
@hawkowl

hawkowl approved these changes Feb 5, 2019

@richvdh richvdh merged commit d7e27a1 into release-v0.99.0 Feb 5, 2019

1 of 5 checks passed

ci/circleci: sytestpy2merged Your tests failed on CircleCI
Details
ci/circleci: sytestpy2postgresmerged Your tests failed on CircleCI
Details
ci/circleci: sytestpy3merged Your tests failed on CircleCI
Details
ci/circleci: sytestpy3postgresmerged Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_config_typo branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment