New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: only copy what we need to the build image #4562

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Feb 5, 2019

There are two reasons this is a good thing:

  • first, it means that you don't end up with stuff kicking around your working
    copy ending up in the build image by mistake (which can upset the pip
    install process)

  • second: it means that the docker image cache is more effective, and we can
    reuse docker images when iterating on the docker stuff.

Docker: only copy what we need to the build image
There are two reasons this is a good thing:

 * first, it means that you don't end up with stuff kicking around your working
   copy ending up in the build image by mistake (which can upset the pip
   install process)

 * second: it means that the docker image cache is more effective, and we can
   reuse docker images when iterating on the docker stuff.

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 5, 2019

@hawkowl

hawkowl approved these changes Feb 5, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #4562 into release-v0.99.0 will decrease coverage by 0.43%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-v0.99.0    #4562      +/-   ##
===================================================
- Coverage            74.91%   74.47%   -0.44%     
===================================================
  Files                  338      338              
  Lines                34495    35093     +598     
  Branches              5619     5789     +170     
===================================================
+ Hits                 25841    26137     +296     
- Misses                7071     7343     +272     
- Partials              1583     1613      +30

@richvdh richvdh merged commit 3ef71a6 into release-v0.99.0 Feb 5, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/hurry_up_docker_build branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment