New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ACME support in the docker image #4566

Merged
merged 8 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Feb 5, 2019

Also:

  • Fix wrapping in docker readme
  • Clean up some docs on the docker image
  • a workaround for #4554

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 5, 2019

@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Feb 5, 2019

fixes #4548 I hope

@anoadragon453
Copy link
Member

anoadragon453 left a comment

Some minor nits

Show resolved Hide resolved docker/README.md Outdated
Show resolved Hide resolved docker/README.md Outdated
Show resolved Hide resolved docker/README.md Outdated
Show resolved Hide resolved docker/README.md Outdated
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #4566 into release-v0.99.0 will decrease coverage by 0.45%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-v0.99.0    #4566      +/-   ##
===================================================
- Coverage            74.91%   74.45%   -0.46%     
===================================================
  Files                  338      338              
  Lines                34495    35093     +598     
  Branches              5619     5789     +170     
===================================================
+ Hits                 25841    26130     +289     
- Misses                7071     7351     +280     
- Partials              1583     1612      +29

anoadragon453 and others added some commits Feb 5, 2019

docker/README.md: review suggestions
Co-Authored-By: richvdh <1389908+richvdh@users.noreply.github.com>
docker/README.md: review suggestions
Co-Authored-By: richvdh <1389908+richvdh@users.noreply.github.com>
docker/README.md: review suggestions
Co-Authored-By: richvdh <1389908+richvdh@users.noreply.github.com>
@anoadragon453
Copy link
Member

anoadragon453 left a comment

Lgtm

@richvdh richvdh merged commit 40b35fb into release-v0.99.0 Feb 5, 2019

1 of 5 checks passed

ci/circleci: sytestpy2merged Your tests failed on CircleCI
Details
ci/circleci: sytestpy2postgresmerged Your tests failed on CircleCI
Details
ci/circleci: sytestpy3merged Your tests failed on CircleCI
Details
ci/circleci: sytestpy3postgresmerged Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/docker_install branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment