Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support starting with no_tls = True and no TLS certificates #4606

Closed
wants to merge 10 commits into from

Conversation

Projects
None yet
3 participants
@hawkowl
Copy link
Contributor

commented Feb 11, 2019

No description provided.

hawkowl added some commits Feb 5, 2019

@hawkowl hawkowl requested a review from matrix-org/synapse-core Feb 11, 2019

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

looks like this is based on #4522

@codecov-io

This comment has been minimized.

Copy link

commented Feb 11, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@c475275). Click here to learn what that means.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             develop    #4606   +/-   ##
==========================================
  Coverage           ?   75.04%           
==========================================
  Files              ?      338           
  Lines              ?    34468           
  Branches           ?     5619           
==========================================
  Hits               ?    25865           
  Misses             ?     7022           
  Partials           ?     1581
if not self.no_tls:
self.tls_private_key = self.read_tls_private_key(self.tls_private_key_file)

self.tls_fingerprints = list(self._original_tls_fingerprints)

This comment has been minimized.

Copy link
@richvdh

richvdh Feb 11, 2019

Member

is this not important?

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

sorry, have superceded this with #4618 and co

@richvdh richvdh closed this Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.