Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle RequestSendFailed exceptions #4643

Merged
merged 2 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

commented Feb 14, 2019

This mainly reduces the number of exceptions we log.

erikjohnston added some commits Feb 14, 2019

Correctly handle RequestSendFailed exceptions
This mainly reduces the number of exceptions we log.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 14, 2019

Codecov Report

Merging #4643 into develop will increase coverage by 0.01%.
The diff coverage is 64.28%.

@@             Coverage Diff             @@
##           develop    #4643      +/-   ##
===========================================
+ Coverage    75.28%   75.29%   +0.01%     
===========================================
  Files          338      338              
  Lines        34579    34585       +6     
  Branches      5655     5656       +1     
===========================================
+ Hits         26032    26040       +8     
  Misses        6957     6957              
+ Partials      1590     1588       -2
@richvdh
Copy link
Member

left a comment

looks plausible

@erikjohnston erikjohnston merged commit d1b060b into develop Feb 18, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 64.28% of diff hit (target 0%)
Details
codecov/project 75.29% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.