Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSERT many functionality #4644

Merged
merged 14 commits into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@hawkowl
Copy link
Contributor

hawkowl commented Feb 14, 2019

No description provided.

hawkowl added some commits Feb 14, 2019

@hawkowl hawkowl requested a review from matrix-org/synapse-core Feb 14, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #4644 into develop will increase coverage by 0.01%.
The diff coverage is 65.85%.

@@             Coverage Diff             @@
##           develop    #4644      +/-   ##
===========================================
+ Coverage    75.14%   75.16%   +0.01%     
===========================================
  Files          340      340              
  Lines        34767    34803      +36     
  Branches      5683     5700      +17     
===========================================
+ Hits         26126    26160      +34     
+ Misses        7035     7033       -2     
- Partials      1606     1610       +4
@richvdh
Copy link
Member

richvdh left a comment

looks generally great. A few nitpicks

Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved synapse/storage/_base.py Outdated
Show resolved Hide resolved synapse/storage/_base.py Outdated
Show resolved Hide resolved synapse/storage/_base.py Outdated
Show resolved Hide resolved synapse/storage/_base.py Outdated

@hawkowl hawkowl requested a review from matrix-org/synapse-core Feb 19, 2019

hawkowl added some commits Feb 19, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm!

@hawkowl hawkowl merged commit a06614b into develop Feb 20, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 65.85% of diff hit (target 0%)
Details
codecov/project 75.16% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.