Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CORS on .well-known URI to unbreak modular #4651

Merged
merged 5 commits into from Feb 18, 2019

Conversation

5 participants
@ara4n
Copy link
Member

ara4n commented Feb 14, 2019

otherwise a riot/web running on foo.riot.im can't query the .well-known on foo.modular.im...

ara4n added some commits Feb 14, 2019

set CORS on .well-known URI to unbreak modular
otherwise a riot/web running on foo.riot.im can't query
the .well-known on foo.modular.im...
@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Feb 14, 2019

fixes #4593 I guess?

@neilisfragile neilisfragile added this to To Do in Homeserver Task Board via automation Feb 14, 2019

@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Feb 14, 2019

yup

@ara4n ara4n requested a review from matrix-org/synapse-core Feb 14, 2019

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Feb 14, 2019

can has changelog entry pls? lgtm otherwise

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Feb 14, 2019

oh, except for the bit where all the CI is failing because you haven't imported set_cors_headers

@richvdh
Copy link
Member

richvdh left a comment

lgtm once you fix the CI

ara4n added some commits Feb 18, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #4651 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4651      +/-   ##
===========================================
- Coverage    75.23%   75.22%   -0.02%     
===========================================
  Files          338      338              
  Lines        34581    34653      +72     
  Branches      5655     5678      +23     
===========================================
+ Hits         26018    26067      +49     
- Misses        6971     6991      +20     
- Partials      1592     1595       +3

@erikjohnston erikjohnston merged commit d08bac4 into develop Feb 18, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 75.22% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh moved this from To Do to Done in Homeserver Task Board Feb 19, 2019

@erikjohnston erikjohnston deleted the matthew/well-known-cors branch Mar 5, 2019

@n1trux

This comment has been minimized.

Copy link

n1trux commented Mar 24, 2019

If you get a 404, the header isn't set, which breaks Riot, for example.

Excerpt from my Chrome network log:

GET https://synapse.example.org/_matrix/identity/api/v1 404
Access to XMLHttpRequest at 'https://synapse.example.org/_matrix/identity/api/v1' from origin 'https://chat.example.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Related: #1595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.