Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kicking guest users in worker mode #4667

Merged
merged 2 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Feb 18, 2019

When guest_access changes from allowed to forbidden all local guest
users should be kicked from the room. This did not happen when
revocation was received from federation on a worker.

Presumably broken in #4141

Fix kicking guest users in worker mode
When guest_access changes from allowed to forbidden all local guest
users should be kicked from the room. This did not happen when
revocation was received from federation on a worker.

Presumably broken in #4141

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 18, 2019

@erikjohnston erikjohnston force-pushed the erikj/fix_revoke_guest_access_workers branch from 2b7013c to e85aabb Feb 18, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #4667 into develop will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #4667      +/-   ##
===========================================
+ Coverage    75.27%   75.27%   +<.01%     
===========================================
  Files          338      338              
  Lines        34626    34627       +1     
  Branches      5670     5670              
===========================================
+ Hits         26064    26066       +2     
- Misses        6966     6968       +2     
+ Partials      1596     1593       -3
@richvdh
Copy link
Member

richvdh left a comment

Hey. What if, every time we made a change, we ran a bunch of tests against it. We could automate it. It would be glorious.

@erikjohnston erikjohnston merged commit c30f73c into develop Feb 18, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 0%)
Details
codecov/project 75.27% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/fix_revoke_guest_access_workers branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.