Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle HttpResponseException when handling device updates #4668

Merged
merged 3 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

commented Feb 18, 2019

No description provided.

@erikjohnston erikjohnston force-pushed the erikj/catch_exceptions branch from e9ed141 to 2f16857 Feb 18, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 18, 2019

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

related: #4643

@richvdh
Copy link
Member

left a comment

sure

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

modulo CI failing

@codecov-io

This comment has been minimized.

Copy link

commented Feb 18, 2019

Codecov Report

Merging #4668 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #4668      +/-   ##
===========================================
- Coverage    75.27%   75.26%   -0.01%     
===========================================
  Files          338      338              
  Lines        34626    34626              
  Branches      5670     5670              
===========================================
- Hits         26064    26062       -2     
- Misses        6966     6972       +6     
+ Partials      1596     1592       -4

@erikjohnston erikjohnston merged commit 459d3d5 into develop Feb 18, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 0%)
Details
codecov/project 75.27% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/catch_exceptions branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.