Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split /login into client_reader #4670

merged 3 commits into from Feb 19, 2019


None yet
3 participants
Copy link

commented Feb 18, 2019

Turns out this was simply moving some more functions into RegistrationWorkerStore

erikjohnston added some commits Feb 18, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 18, 2019


This comment has been minimized.

Copy link

commented Feb 18, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@fc2c245). Click here to learn what that means.
The diff coverage is 80%.

@@            Coverage Diff             @@
##             develop    #4670   +/-   ##
  Coverage           ?   75.16%           
  Files              ?      340           
  Lines              ?    34714           
  Branches           ?     5677           
  Hits               ?    26094           
  Misses             ?     7018           
  Partials           ?     1602
Copy link

left a comment


@erikjohnston erikjohnston merged commit 32590b7 into develop Feb 19, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
codecov/patch 80% of diff hit (target 0%)
codecov/project 75.16% (target 0%)
continuous-integration/travis-ci/pr The Travis CI build passed

@erikjohnston erikjohnston deleted the erikj/register_login_split branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.