Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Postgres 9.5 as well as 9.4 #4676

Merged
merged 1 commit into from Feb 19, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Feb 19, 2019

Postgres 9.5 is the first to support UPSERTs, so we should really run against
it as well as 9.4.

Test against Postgres 9.5 as well as 9.4
Postgres 9.5 is the first to support UPSERTs, so we should really run against
it as well as 9.4.

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 19, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #4676 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4676      +/-   ##
===========================================
+ Coverage    75.17%   75.19%   +0.01%     
===========================================
  Files          340      340              
  Lines        34712    34712              
  Branches      5677     5677              
===========================================
+ Hits         26096    26101       +5     
+ Misses        7013     7008       -5     
  Partials      1603     1603
@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Feb 19, 2019

I would be sorely tempted to only test pg9.4 on py2.7 and a later postgres on 3.6, but meh.

Do we want to test py3.7 instead of 3.6?

@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Feb 19, 2019

I would be sorely tempted to only test pg9.4 on py2.7 and a later postgres on 3.6, but meh.

maybe... we can always change it later I guess.

Do we want to test py3.7 instead of 3.6?

probably, but it's slightly non-trivial. Will make it a separate PR.

@richvdh richvdh merged commit 1c0eb8b into develop Feb 19, 2019

8 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d154f5a...0869f01
Details
codecov/project 75.19% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/pg95 branch Feb 20, 2019

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Feb 21, 2019

@richvdh richvdh moved this from To Do to Done in Homeserver Task Board Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.