Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DINSIC] Use internal-info for identity server #4681

Merged
merged 4 commits into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@anoadragon453
Copy link
Member

anoadragon453 commented Feb 19, 2019

Switches Synapse to use Sydent's new /internal-info API for information about 3PIDs when registering a new user.

Uses the new requires_invite field to check if a registration should be allowed.

Sydent PR: matrix-org/sydent#106

@anoadragon453 anoadragon453 force-pushed the dinsic_anoa/info_split branch from dc56385 to 70e039c Feb 19, 2019

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Feb 25, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm otherwise.

Show resolved Hide resolved synapse/util/threepids.py Outdated
Update synapse/util/threepids.py
Co-Authored-By: anoadragon453 <1342360+anoadragon453@users.noreply.github.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (dinsic@2712a9e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dinsic    #4681   +/-   ##
=========================================
  Coverage          ?   72.07%           
=========================================
  Files             ?      335           
  Lines             ?    34019           
  Branches          ?        0           
=========================================
  Hits              ?    24518           
  Misses            ?     9501           
  Partials          ?        0
Impacted Files Coverage Δ
synapse/rest/client/v2_alpha/register.py 56.14% <ø> (ø)
synapse/rest/client/v2_alpha/account.py 59.01% <ø> (ø)
synapse/util/threepids.py 23.8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2712a9e...0a23bf4. Read the comment docs.

@anoadragon453 anoadragon453 requested a review from richvdh Feb 27, 2019

@richvdh
Copy link
Member

richvdh left a comment

sure, I guess.

@anoadragon453 anoadragon453 merged commit 3271742 into dinsic Feb 28, 2019

0 of 4 checks passed

ci/circleci: sytestpy2merged Your tests failed on CircleCI
Details
ci/circleci: sytestpy2postgresmerged Your tests failed on CircleCI
Details
ci/circleci: sytestpy3merged Your tests failed on CircleCI
Details
ci/circleci: sytestpy3postgresmerged Your tests failed on CircleCI
Details

@anoadragon453 anoadragon453 deleted the dinsic_anoa/info_split branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.