Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration on workers #4682

Merged
merged 4 commits into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Feb 19, 2019

There turns out to be a bunch of code paths not tested by sytest, including adding threepids and accepting ToS.

We fix this by adding a replication API to run post registration actions. We run this as a separate step, rather than as part of the existing replication API, mainly to reduce the amount of refactoring that would otherwise need to happen.

c.f. #4666

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #4682 into develop will decrease coverage by 0.04%.
The diff coverage is 45.65%.

@@             Coverage Diff             @@
##           develop    #4682      +/-   ##
===========================================
- Coverage    75.19%   75.14%   -0.05%     
===========================================
  Files          340      340              
  Lines        34736    34767      +31     
  Branches      5680     5683       +3     
===========================================
+ Hits         26119    26126       +7     
- Misses        7014     7037      +23     
- Partials      1603     1604       +1
@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Feb 19, 2019

The individual commits should be fairly stand alone.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 19, 2019

@hawkowl

This comment has been minimized.

Copy link
Contributor

hawkowl commented Feb 20, 2019

Looks fine.

@hawkowl hawkowl merged commit dbdc565 into develop Feb 20, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 45.65% of diff hit (target 0%)
Details
codecov/project 75.14% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the erikj/fix_registration_workers branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.