Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up gitignores #4688

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

commented Feb 20, 2019

I just got bitten by a file being caught by the .gitignore, which shouldn't have been, and am now pissed off with the .gitignore. I have basically declared bankruptcy on it and started again.

Clean up gitignores
I just got bitten by a file being caught by the .gitignore, which shouldn't
have been, and am now pissed off with the .gitignore. I have basically declared
bankruptcy on it and started again.

@richvdh richvdh changed the title Attempt to clarify installation/config instructions Clean up gitignores Feb 20, 2019

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 20, 2019

@erikjohnston
Copy link
Member

left a comment

Sure

@richvdh richvdh merged commit 8d98dc8 into develop Feb 20, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

@richvdh richvdh deleted the rav/gitignore branch Feb 20, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 20, 2019

Codecov Report

Merging #4688 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4688      +/-   ##
===========================================
- Coverage    75.14%   75.14%   -0.01%     
===========================================
  Files          340      340              
  Lines        34767    34767              
  Branches      5683     5683              
===========================================
- Hits         26126    26124       -2     
- Misses        7035     7037       +2     
  Partials      1606     1606

@aaronraimist aaronraimist referenced this pull request Mar 9, 2019

Merged

Add some stuff back to the .gitignore #4843

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.