Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements for the pusher #4691

Merged
merged 2 commits into from Feb 20, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Feb 20, 2019

  • Don't log massive exception stacktraces the entire time
  • reduce the amount of logging in startup

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 20, 2019

except Exception as e:
logger.warning(
"Failed to push event %s to %s: %s %s",
event.event_id, self.name, type(e), e,

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Feb 20, 2019

Member

I'm a bit cautious about catching all the exceptions here in case it masks actual programming exceptions, can we not catch HttpResponseException etc?

OTOH, it was already logging at warning, so this isn't the end of the world

This comment has been minimized.

Copy link
@richvdh

richvdh Feb 20, 2019

Author Member

wellll....

normally I'd agree with you, but the exception that was causing a problem is a twisted.web._newclient.RequestGenerationFailed: [<twisted.python.failure.Failure twisted.internet.defer.CancelledError: >]. AFAICT that doesn't seem to be part of twisted's public interface, so it seems to be not a great idea to try and catch it here.

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Feb 20, 2019

Member

Oh great. It also doesn't look like I added RequestSendFailed stuff to the normal http client either.

@richvdh richvdh merged commit b2200a8 into develop Feb 20, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

@richvdh richvdh deleted the rav/pusher_logging branch Feb 20, 2019

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Feb 21, 2019

@richvdh richvdh moved this from To Do to Done in Homeserver Task Board Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.