Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup generated metrics config #4694

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Feb 20, 2019

Now looks like:

## Metrics ###

# Enable collection and rendering of performance metrics
enable_metrics: False

# Enable sentry integration
# NOTE: While attempts are made to ensure that the logs don't contain
# any sensitive information, this cannot be guaranteed. By enabling
# this option the sentry server may therefore receive sensitive
# information, and it in turn may then diseminate sensitive information
# through insecure notification channels if so configured.
#sentry:
#    dsn: "..."

# Whether or not to report anonymized homeserver usage statistics.
report_stats: true

Broke by #4632

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 20, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #4694 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4694      +/-   ##
===========================================
+ Coverage    75.13%   75.16%   +0.03%     
===========================================
  Files          340      340              
  Lines        34811    34811              
  Branches      5701     5701              
===========================================
+ Hits         26155    26166      +11     
+ Misses        7046     7036      -10     
+ Partials      1610     1609       -1

@erikjohnston erikjohnston merged commit 82fca11 into develop Feb 20, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a06614b...633e5c9
Details
codecov/project 75.16% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/fix_sentry_config_format branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.