Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better checks on newsfragments #4698

Merged
merged 1 commit into from Feb 22, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Feb 20, 2019

  • You need an entry in the debian changelog (and not a regular newsfragment)
    for debian packaging changes.
  • Regular newsfragments must end in full stops.
Better checks on newsfragments
* You need an entry in the debian changelog (and not a regular newsfragment)
  for debian packaging changes.
* Regular newsfragments must end in full stops.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #4698 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4698      +/-   ##
===========================================
+ Coverage    75.15%   75.17%   +0.02%     
===========================================
  Files          340      340              
  Lines        34814    34814              
  Branches      5702     5702              
===========================================
+ Hits         26165    26172       +7     
+ Misses        7037     7034       -3     
+ Partials      1612     1608       -4
1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #4698 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4698      +/-   ##
===========================================
+ Coverage    75.15%   75.17%   +0.02%     
===========================================
  Files          340      340              
  Lines        34814    34814              
  Branches      5702     5702              
===========================================
+ Hits         26165    26172       +7     
+ Misses        7037     7034       -3     
+ Partials      1612     1608       -4

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 21, 2019

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Feb 21, 2019

@richvdh richvdh moved this from To Do to In progress in Homeserver Task Board Feb 21, 2019

@richvdh richvdh merged commit e1666af into develop Feb 22, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 82fca11...2f335cf
Details
codecov/project 75.17% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Homeserver Task Board automation moved this from In progress to Done Feb 22, 2019

@richvdh richvdh deleted the rav/newscheck branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.